Skip to content

Fix sphinx-lint after #31097 and b878b3a#31248

Merged
miss-islington merged 1 commit intopython:mainfrom
sobolevn:fix-sphinx-lint
Feb 10, 2022
Merged

Fix sphinx-lint after #31097 and b878b3a#31248
miss-islington merged 1 commit intopython:mainfrom
sobolevn:fix-sphinx-lint

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 10, 2022 •
edited by miss-islington
Loading

main branch is failing, see https://dev.azure.com/python/cpython/_build/results?buildId=96616&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171

Logs:

PATH=./venv/bin:$PATH sphinx-lint -i tools -i ./venv -i README.rst
No problems found.
PATH=./venv/bin:$PATH sphinx-lint ../Misc/NEWS.d/next/
[1] ../Misc/NEWS.d/next/Library/2022-02-09-00-53-23.[bpo-45863](https://bugs.python.org/issue45863).zqQXVv.rst:0: No newline at end of file (no-newline-at-end-of-file).
[1] ../Misc/NEWS.d/next/Build/2022-01-19-11-08-32.[bpo-46430](https://bugs.python.org/issue46430).k403m_.rst:0: No newline at end of file (no-newline-at-end-of-file).
2 problems with severity 1 found.

This PR fixes these two problems, so main is green again.

Related PR: #31097
CC @JulienPalard

Automerge-Triggered-By: GH:JulienPalard

@JulienPalard
Copy link
Member

JulienPalard commented Feb 10, 2022

Oops I should have rebased right before merging this one, I'm looking at it!

@JulienPalard
Copy link
Member

JulienPalard commented Feb 10, 2022

Thanks @sobolevn for the fast PR :)

@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2022

@sobolevn: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit dee020a into python:main Feb 10, 2022
@vstinner
Copy link
Member

vstinner commented Feb 10, 2022

I backported the tarfile change to 3.9 and 3.10, do these branches also need a fix? https://bugs.python.org/issue45863

@vstinner
Copy link
Member

vstinner commented Feb 10, 2022

main branch is failing, see https://dev.azure.com/python/cpython/_build/results?buildId=96616&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171

I didn't notice the failure on the PR #29693

Is it because the branch is old (Nov 2021) and was not rebased before being merged? Maybe the strict CI tests were added later?

@sobolevn
Copy link
Member Author

sobolevn commented Feb 10, 2022

Is it because the branch is old (Nov 2021) and was not rebased before being merged? Maybe the strict CI tests were added later?

Yes, looks like this is the case.

@JulienPalard
Copy link
Member

JulienPalard commented Feb 10, 2022

do these branches also need a fix?

I did not backported sphinx-lint to old branch and I don't want to, rstlint does an OK job on those branche, sphinx-lint is very new, main is enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @JulienPalard @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot